Adding string parsing to Weekday.#5
Open
LennartCode wants to merge 1 commit intopcekm:mainfrom
Open
Conversation
pcekm
requested changes
Apr 10, 2026
Owner
pcekm
left a comment
pcekm
left a comment
There was a problem hiding this comment.
Thanks for the contribution. Your implementation looks fine to me. Please add a couple of simple unit tests (one success, one failure), and update CHANGELOG.md (under a section called "[unreleased]").
Comment on lines
+29
to
+31
| /// Parses a string to a weekday. | ||
| /// | ||
| /// Takes a lower-case weekday name in English and returns the respective enumerated value. |
Owner
There was a problem hiding this comment.
Lets focus more on the idea that this is the inverse of the name field. The fact that it's english isn't all that important. Something like "Parses the output of [name]." You could probably get away with just that single line and no other explanation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes #4 as two-letter representations are not planned.